[Data] Re-add parallelism parameter to read_snowflake#57795
Merged
bveeramani merged 2 commits intoray-project:masterfrom Oct 17, 2025
Merged
[Data] Re-add parallelism parameter to read_snowflake#57795bveeramani merged 2 commits intoray-project:masterfrom
bveeramani merged 2 commits intoray-project:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-adds the parallelism parameter to read_snowflake, which is a good fix. However, the newly added parameter is currently not used within the function body, nor is it documented. To complete this change, the parallelism parameter should be passed to the read_sql call and its purpose should be documented in the docstring, noting that it is deprecated in favor of override_num_blocks.
gvspraveen
approved these changes
Oct 17, 2025
was added in PR ray-project#56588 , but got lost again in a latter PR ray-project#56419 Signed-off-by: jpatra72 <jyotirmaya72@gmail.com>
Signed-off-by: jpatra72 <jyotirmaya72@gmail.com>
bveeramani
approved these changes
Oct 17, 2025
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
) was added in PR ray-project#56588 , but got lost again in a latter PR ray-project#56419 --------- Signed-off-by: jpatra72 <jyotirmaya72@gmail.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
) was added in PR ray-project#56588 , but got lost again in a latter PR ray-project#56419 --------- Signed-off-by: jpatra72 <jyotirmaya72@gmail.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
) was added in PR ray-project#56588 , but got lost again in a latter PR ray-project#56419 --------- Signed-off-by: jpatra72 <jyotirmaya72@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
) was added in PR ray-project#56588 , but got lost again in a latter PR ray-project#56419 --------- Signed-off-by: jpatra72 <jyotirmaya72@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
) was added in PR ray-project#56588 , but got lost again in a latter PR ray-project#56419 --------- Signed-off-by: jpatra72 <jyotirmaya72@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
was added in PR #56588 , but got lost again in a latter PR #56419
Related issues
Types of change
Checklist
Does this PR introduce breaking changes?
Testing:
Code Quality:
git commit -s)Documentation:
doc/source/(if applicable)Additional context