[core] remove dead open telemetry code#53709
Merged
can-anyscale merged 1 commit intomasterfrom Jun 10, 2025
Merged
Conversation
Signed-off-by: can <can@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused OpenTelemetry code and its associated test targets, streamlining the stats module by deleting dead example implementations.
- Deleted the dummy OpenTelemetry metrics implementation (
opentelemetry_metrics.cc) and its test. - Removed BUILD targets referencing the obsolete example code.
- Adjusted test and library BUILD files to drop unused dependencies.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ray/stats/tests/opentelemetry_metrics_test.cc | Entire file deleted (dummy test removed) |
| src/ray/stats/tests/BUILD | Removed opentelemetry_metrics_test target |
| src/ray/stats/opentelemetry_metrics.cc | Deleted example telemetry implementation |
| src/ray/stats/BUILD.bazel | Removed stats_opentelemetry library rule |
edoakes
approved these changes
Jun 10, 2025
nrghosh
pushed a commit
to nrghosh/ray
that referenced
this pull request
Jun 10, 2025
Remove some open telemetry code that was added in ray-project#51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Remove some open telemetry code that was added in #51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Remove some open telemetry code that was added in #51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some open telemetry code that was added in #51077. These files were added to test the complication of the open telemetry library, but we never end up using these files.
Test: