[core] Checkin opentelemetry C++ sdk dependency#51077
[core] Checkin opentelemetry C++ sdk dependency#51077edoakes merged 4 commits intoray-project:masterfrom
Conversation
Signed-off-by: dentiny <dentinyhao@gmail.com>
|
Looks fine, but let's check it in with the code that uses it? |
aslonnie
left a comment
There was a problem hiding this comment.
Looks fine, but let's check it in with the code that uses it?
+1, maybe use it at least for once? otherwise it is hard to tell if the import works.
Signed-off-by: dentiny <dentinyhao@gmail.com>
I thought about that, the most ideal way is to have a basic replacement implementation for metrics class that we have, but checking the codebase there're much work to do. One concern is the compatibility between opencensus vs opentelemetry, like the default endpoint. But I think your argument makes sense; I add a simple "test script" to show dependency checkin has no problem. |
Signed-off-by: dentiny <dentinyhao@gmail.com>
adc90cc to
b9da27f
Compare
|
Thanks for taking this on! Just to confirm, this is just to add the open telemetry dependency and there will be followup PRs to fix the breaking changes (https://opentelemetry.io/docs/specs/otel/compatibility/opencensus/) between the OpenCensus and OPTL, is that correct? |
Yes, my plan is to implement a compatible metrics class, which is a counterpart for existing class, later on migrate metrics usage one by one. |
I'm wondering other than the metrics classes, whether the metrics collectors and exporters needs to be updated as well. |
[opencensus](https://github.com/census-instrumentation/opencensus-cpp) has been archived for ~2 years, we should upgrade to opentelemetry which is the somewhat an "improved" and maintained version. --------- Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
[opencensus](https://github.com/census-instrumentation/opencensus-cpp) has been archived for ~2 years, we should upgrade to opentelemetry which is the somewhat an "improved" and maintained version. --------- Signed-off-by: dentiny <dentinyhao@gmail.com>
[opencensus](https://github.com/census-instrumentation/opencensus-cpp) has been archived for ~2 years, we should upgrade to opentelemetry which is the somewhat an "improved" and maintained version. --------- Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Remove some open telemetry code that was added in #51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com>
Remove some open telemetry code that was added in ray-project#51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com>
Remove some open telemetry code that was added in #51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Remove some open telemetry code that was added in #51077. These files were added to test the complication of the open telemetry library, but we never end up using these files. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
opencensus has been archived for ~2 years, we should upgrade to opentelemetry which is the somewhat an "improved" and maintained version.