Support direct actor call by zhijunfu · Pull Request #5183 · ray-project/ray

zhijunfu · 2019-07-12T08:06:20Z

What do these changes do?

This change adds support for direct actor call, using unary grpc.

Here are the major changes:

adds a transport for direct actor call.
adds test cases for direct actor tasks, actor failure, and actor failover scenarios.

Related issue number

#5029

Linter

[Y] I've run scripts/format.sh to lint the changes in this PR.

Co-Authored-By: Hao Chen <chenh1024@gmail.com>

…ch-alliance/ray into add_grpc_server_to_worker

Co-Authored-By: Stephanie Wang <swang@cs.berkeley.edu>

AmplabJenkins · 2019-07-25T19:59:54Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15657/
Test FAILed.

AmplabJenkins · 2019-07-25T20:14:54Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15656/
Test FAILed.

AmplabJenkins · 2019-07-25T20:42:52Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15661/
Test FAILed.

AmplabJenkins · 2019-07-25T21:35:36Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15660/
Test PASSed.

zhijunfu · 2019-07-26T07:07:41Z

Comments are addressed. Would you please help take another look?
Kindly let me know if you have additional comments, or if this is ready to merge:) Thanks!

@raulchen @ericl @robertnishihara @micafan

raulchen

Just left some comments about the tests. Other code looks good to me.

src/ray/core_worker/transport/direct_actor_transport.h

src/ray/core_worker/test/core_worker_test.cc

Co-Authored-By: Hao Chen <chenh1024@gmail.com>

AmplabJenkins · 2019-07-26T09:53:17Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15673/
Test PASSed.

AmplabJenkins · 2019-07-26T10:14:18Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15674/
Test PASSed.

AmplabJenkins · 2019-07-26T12:34:40Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15680/
Test PASSed.

…nce/ray into direct_actor_call

zhijunfu · 2019-07-26T13:28:54Z

ok, just addressed another around of comments. thanks.

AmplabJenkins · 2019-07-26T16:24:17Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15681/
Test PASSed.

…ct_actor_call

AmplabJenkins · 2019-07-27T05:32:53Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15702/
Test PASSed.

raulchen

LGTM. @ericl @robertnishihara Do you want to take a look again?

raulchen

Found a few more small issues.

src/ray/core_worker/test/util.h

src/ray/core_worker/transport/direct_actor_transport.cc

AmplabJenkins · 2019-07-30T08:49:13Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15781/
Test PASSed.

zhijunfu and others added 30 commits June 24, 2019 16:02

refactor grpc server

7f635b4

format

2205c87

change GetTask() to PushTask()

0703b75

merge code, and fix test

6d5228a

merge

4c3eb6e

change PushTask to AssignTask

d1b20e5

format

1a663bc

update

fb1f55f

fix test

3c68b9d

format

5842653

merge

eb413e5

merge with latest code

f4ad236

Update src/ray/rpc/worker_client.h

e6b3e45

Co-Authored-By: Hao Chen <chenh1024@gmail.com>

merge latest code, and resolve comments

cd8ebf1

Merge branch 'add_grpc_server_to_worker' of https://github.com/ant-te…

4f98af9

…ch-alliance/ray into add_grpc_server_to_worker

Update BUILD.bazel

6e659c9

merge

dc3788e

format

16eb2e4

merge

1317657

add missing files

fb8d375

merge

4ef00b2

add resource_ids

6caa126

move done_callback to server call

302e79f

remove SetTaskHandler and initialize it in task receiver's constructor

70d6e26

format

17b22e4

resolve comments

dbf666c

update

a5f301d

update

0c762f1

Update src/ray/core_worker/core_worker.cc

819614f

Co-Authored-By: Stephanie Wang <swang@cs.berkeley.edu>

resolve comments

beb01be

zhijunfu added 3 commits July 26, 2019 14:55

reduce copy of TaskSpec

0e858eb

format

0ebbf04

merge

766bccc

raulchen reviewed Jul 26, 2019

View reviewed changes

Update src/ray/core_worker/test/core_worker_test.cc

71e42d6

Co-Authored-By: Hao Chen <chenh1024@gmail.com>

zhijunfu added 3 commits July 26, 2019 21:22

resolve comments

7940d86

cleanup rpc client when dead/reconstructing

04971dd

Merge branch 'direct_actor_call' of https://github.com/ant-tech-allia…

017aaee

…nce/ray into direct_actor_call

zhijunfu added 2 commits July 27, 2019 09:39

Merge branch 'master' of https://github.com/ray-project/ray into dire…

b84ae50

…ct_actor_call

format

5cb684b

raulchen approved these changes Jul 28, 2019

View reviewed changes

raulchen reviewed Jul 29, 2019

View reviewed changes

src/ray/core_worker/test/util.h Show resolved Hide resolved

src/ray/core_worker/transport/direct_actor_transport.cc Show resolved Hide resolved

src/ray/core_worker/transport/direct_actor_transport.cc Outdated Show resolved Hide resolved

zhijunfu added 2 commits July 30, 2019 13:41

fix ci issues

1bc8375

resolve comments

a522ec0

raulchen merged commit eb307f9 into ray-project:master Jul 30, 2019

raulchen deleted the direct_actor_call branch July 30, 2019 09:47

edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019

Support direct actor call (ray-project#5183)

bfbbd66

kfstorm mentioned this pull request Aug 22, 2019

[Java] Support direct actor call in Java worker #5504

Merged

3 tasks

Conversation

zhijunfu commented Jul 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What do these changes do?

Related issue number

Linter

Uh oh!

AmplabJenkins commented Jul 25, 2019

Uh oh!

AmplabJenkins commented Jul 25, 2019

Uh oh!

AmplabJenkins commented Jul 25, 2019

Uh oh!

AmplabJenkins commented Jul 25, 2019

Uh oh!

zhijunfu commented Jul 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raulchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AmplabJenkins commented Jul 26, 2019

Uh oh!

AmplabJenkins commented Jul 26, 2019

Uh oh!

AmplabJenkins commented Jul 26, 2019

Uh oh!

zhijunfu commented Jul 26, 2019

Uh oh!

AmplabJenkins commented Jul 26, 2019

Uh oh!

AmplabJenkins commented Jul 27, 2019

Uh oh!

raulchen left a comment

Choose a reason for hiding this comment

Uh oh!

raulchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AmplabJenkins commented Jul 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zhijunfu commented Jul 12, 2019 •

edited

Loading

zhijunfu commented Jul 26, 2019 •

edited

Loading