Skip to content

[serve] Integrate and Document Bring-Your-Own Gradio Applications (#2…#27560

Merged
simon-mo merged 2 commits intoray-project:releases/2.0.0from
zcin:gradio_integration
Aug 5, 2022
Merged

[serve] Integrate and Document Bring-Your-Own Gradio Applications (#2…#27560
simon-mo merged 2 commits intoray-project:releases/2.0.0from
zcin:gradio_integration

Conversation

@zcin
Copy link
Copy Markdown
Contributor

@zcin zcin commented Aug 5, 2022

…6403)

Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using GradioIngress, and scale it up through more replicas or more CPU/GPU resources.

Signed-off-by: Cindy Zhang cindyzyx9@gmail.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…y-project#26403)

Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using `GradioIngress`, and scale it up through more replicas or more CPU/GPU resources.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin marked this pull request as ready for review August 5, 2022 19:08
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>

import starlette

try:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super sorry, I had written a "hacky" way of telling the user when they don't have gradio installed, and forgot to change it before this got merged into master. The "hacky" way has correct functionality but ugly code. I've pushed a new commit fixing this for now, let me know if this should be reverted for another approach!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok to merge

@simon-mo simon-mo merged commit 419ba8e into ray-project:releases/2.0.0 Aug 5, 2022
zcin added a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants