[serve] Integrate and Document Bring-Your-Own Gradio Applications#26403
[serve] Integrate and Document Bring-Your-Own Gradio Applications#26403edoakes merged 11 commits intoray-project:masterfrom
Conversation
edoakes
left a comment
There was a problem hiding this comment.
Awesome work on the documentation!
python/ray/serve/gradio.py
Outdated
There was a problem hiding this comment.
Is this a public API that's guaranteed by gradio to remain stable?
There was a problem hiding this comment.
Not that I know of. Should we sync with Gradio team on this?
There was a problem hiding this comment.
Yes, definitely. We need to make sure any APIs we use are public & stable otherwise our integration could break at any point without warning.
There was a problem hiding this comment.
Abubakar confirmed that this API will remain stable, and they will add tests around gr.routes.App.create_app() to make sure the API signature doesn't change!
There was a problem hiding this comment.
nit: use async def as best practice :)
There was a problem hiding this comment.
Unfortunately Gradio doesn't support async functions in gr.Interface yet :(
shrekris-anyscale
left a comment
There was a problem hiding this comment.
Great work so far on this integration! I've added some comments.
shrekris-anyscale
left a comment
There was a problem hiding this comment.
Nice updates! I added some comments for the documentation.
.buildkite/pipeline.yml
Outdated
There was a problem hiding this comment.
you should also filter out this test from regular test suites both in windows (ci.sh) and here.
doc/source/serve/tutorials/index.md
Outdated
There was a problem hiding this comment.
Got it, I'll remove the actual file as well.
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
shrekris-anyscale
left a comment
There was a problem hiding this comment.
Nice work so far! I had a small nit about the section titling, but other that that, this change looks pretty good.
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
…y-project#26403) Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using `GradioIngress`, and scale it up through more replicas or more CPU/GPU resources. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
…y-project#26403) Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using `GradioIngress`, and scale it up through more replicas or more CPU/GPU resources. Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
…ions (ray-project#26403)" (ray-project#27587) This reverts commit 8a9d994. Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Why are these changes needed?
Integration between Ray Serve and Gradio. Users of Gradio can wrap their Gradio app in a Serve deployment by using
GradioIngress, and scale it up through more replicas or more CPU/GPU resources.Related issue number
Checks
scripts/format.shto lint the changes in this PR.