Skip to content

Cleanup ActorContext due to multi actor instances got removed.#26497

Merged
jovany-wang merged 1 commit intoray-project:masterfrom
jovany-wang:cleanup
Jul 15, 2022
Merged

Cleanup ActorContext due to multi actor instances got removed.#26497
jovany-wang merged 1 commit intoray-project:masterfrom
jovany-wang:cleanup

Conversation

@jovany-wang
Copy link
Copy Markdown
Contributor

@jovany-wang jovany-wang commented Jul 13, 2022

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jovany-wang jovany-wang mentioned this pull request Jul 13, 2022
Closed
16 tasks
WangTaoTheTonic
WangTaoTheTonic approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@WangTaoTheTonic WangTaoTheTonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovany-wang
Cleanup
fe57644 
Signed-off-by: Qing Wang <kingchin1218@gmail.com>
@jovany-wang
Copy link
Copy Markdown
Contributor Author

jovany-wang commented Jul 15, 2022

Failures are unrelated.

@jovany-wang jovany-wang merged commit e301f9b into ray-project:master Jul 15, 2022
@jovany-wang jovany-wang deleted the cleanup branch July 15, 2022 15:30
xwjiang2010 pushed a commit to xwjiang2010/ray that referenced this pull request Jul 19, 2022
@jovany-wang @xwjiang2010
Cleanup ActorContext due to multi actor instances got removed. (ray-p…
07ad26a 
…roject#26497)

Signed-off-by: Xiaowei Jiang <xwjiang2010@gmail.com>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@jovany-wang
Cleanup ActorContext due to multi actor instances got removed. (ray-p…
606f5ad 
…roject#26497)

Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
@codope codope mentioned this pull request May 29, 2025
Merged
edoakes pushed a commit that referenced this pull request Jun 2, 2025
@codope
[core] Remove unused on_worker_shutdown callback from the core work…
ff178fd 
…er (#53389)

Just removing an unused relic. 

`on_worker_shutdown` callback was introduced in #11324 (in case of
multiple workers per Java process) but later removed in #26497

Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WangTaoTheTonic WangTaoTheTonic WangTaoTheTonic approved these changes

@kfstorm kfstorm Awaiting requested review from kfstorm kfstorm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jovany-wang @WangTaoTheTonic