Skip to content

[core] Remove unused on_worker_shutdown callback from the core worker#53389

Merged
edoakes merged 1 commit intoray-project:masterfrom
codope:cleanup_on_worker_shutdown
Jun 2, 2025
Merged

[core] Remove unused on_worker_shutdown callback from the core worker#53389
edoakes merged 1 commit intoray-project:masterfrom
codope:cleanup_on_worker_shutdown

Conversation

@codope
Copy link
Copy Markdown
Contributor

@codope codope commented May 29, 2025

Why are these changes needed?

Just removing an unused relic.

on_worker_shutdown callback was introduced in #11324 (in case of multiple workers per Java process) but later removed in #26497

@codope codope added go add ONLY when ready to merge, run all tests core Issues that should be addressed in Ray Core labels May 29, 2025
Copy link
Copy Markdown
Contributor

@israbbani israbbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
@codope codope force-pushed the cleanup_on_worker_shutdown branch from 06bbdc4 to 233db2e Compare June 2, 2025 12:42
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 2, 2025

🔥

@edoakes edoakes enabled auto-merge (squash) June 2, 2025 15:20
@edoakes edoakes merged commit ff178fd into ray-project:master Jun 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants