[tune] Remove Trainable.update_resources#22471
Merged
richardliaw merged 4 commits intoray-project:masterfrom Feb 25, 2022
Merged
[tune] Remove Trainable.update_resources#22471richardliaw merged 4 commits intoray-project:masterfrom
Trainable.update_resources#22471richardliaw merged 4 commits intoray-project:masterfrom
Conversation
xwjiang2010
approved these changes
Feb 22, 2022
Contributor
xwjiang2010
left a comment
There was a problem hiding this comment.
Thanks for the change! Let's just wait for the tests to finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This API wasn't useful in the first place and was made obsolete by being able to access the current Trainable resources by
Trainable.trial_resources.Related issue number
Closes #22392
Checks
scripts/format.shto lint the changes in this PR.