[jobs] Add unit test for parse_cluster_info#22205
Merged
edoakes merged 3 commits intoray-project:masterfrom Feb 8, 2022
Merged
[jobs] Add unit test for parse_cluster_info#22205edoakes merged 3 commits intoray-project:masterfrom
parse_cluster_info#22205edoakes merged 3 commits intoray-project:masterfrom
Conversation
edoakes
approved these changes
Feb 8, 2022
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
Thanks, appreciate the follow-through!
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
Add unit test to check addresses of various formats are correctly passed to `get_job_submission_client_cluster_info`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add unit test to check addresses of various formats are correctly passed to
get_job_submission_client_cluster_info.Related issue number
Follow up from #22116
Checks
scripts/format.shto lint the changes in this PR.