[jobs] Support ray client format of connection string address for external module#22116
Merged
edoakes merged 2 commits intoray-project:masterfrom Feb 4, 2022
Merged
Conversation
Collaborator
|
@nikitavemuri just to check, this is only fixing |
edoakes
approved these changes
Feb 4, 2022
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
It would be great if we had a test that actually imported a mocked-out module, it's a bit scary that we don't.
Contributor
Author
|
Yes, |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray client currently supports connection strings for external modules of the format
"other_module://", howeverray jobcommands don't support this format because trailing/is removed. Update soray jobcommands also support this format.Related issue number
Closes #22119
Checks
scripts/format.shto lint the changes in this PR.