Skip to content

Adds Valgrind tests for multi-threaded object manager.#1890

Merged
pcmoritz merged 6 commits intoray-project:masterfrom
elibol:melih/om_valgrind
Apr 14, 2018
Merged

Adds Valgrind tests for multi-threaded object manager.#1890
pcmoritz merged 6 commits intoray-project:masterfrom
elibol:melih/om_valgrind

Conversation

@elibol
Copy link
Copy Markdown
Contributor

@elibol elibol commented Apr 13, 2018

Adds Valgrind tests for multi-threaded object manager.

@elibol elibol requested a review from pcmoritz April 13, 2018 00:29
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4843/
Test FAILed.

@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented Apr 13, 2018

retest this please

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4845/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4844/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4846/
Test FAILed.

@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented Apr 13, 2018

retest this please

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4850/
Test PASSed.

@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented Apr 13, 2018

on travis the test seems to be hanging: https://travis-ci.com/robertnishihara/ray-private-travis/jobs/119180278

@elibol
Copy link
Copy Markdown
Contributor Author

elibol commented Apr 13, 2018 •
edited
Loading

I think the hanging is fixed by the changes in #1891. I've updated the tests here to reflect the changes in that PR: https://travis-ci.com/robertnishihara/ray-private-travis/builds/70741390

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4866/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4885/
Test FAILed.

@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented Apr 13, 2018

retest this please

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 13, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4890/
Test FAILed.

@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented Apr 14, 2018

retest this please

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 14, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4892/
Test FAILed.

@pcmoritz pcmoritz force-pushed the melih/om_valgrind branch from 2c73b0c to 09fc2b2 Compare April 14, 2018 03:45
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 14, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4894/
Test PASSed.

@pcmoritz pcmoritz merged commit 6be7335 into ray-project:master Apr 14, 2018
royf added a commit to royf/ray that referenced this pull request Apr 22, 2018
@royf
Merge branch 'master' into softq
40ed3a0 
* master: (56 commits)
  [xray] Turn on flushing to the GCS for the lineage cache (ray-project#1907)
  Single Big Object Parallel Transfer. (ray-project#1827)
  Remove num_threads as a parameter. (ray-project#1891)
  Adds Valgrind tests for multi-threaded object manager. (ray-project#1890)
  Pin cython version in docker base dependencies file. (ray-project#1898)
  Update arrow to efficiently serialize more types of numpy arrays. (ray-project#1889)
  updates (ray-project#1896)
  [DataFrame] Inherit documentation from Pandas (ray-project#1727)
  Update arrow and parquet-cpp. (ray-project#1875)
  raylet command line resource configuration plumbing (ray-project#1882)
  use raylet for remote ray nodes (ray-project#1880)
  [rllib] Propagate dim option to deepmind wrappers (ray-project#1876)
  [RLLib] DDPG (ray-project#1685)
  Lint Python files with Yapf (ray-project#1872)
  [DataFrame] Fixed repr, info, and memory_usage (ray-project#1874)
  Fix getattr compat (ray-project#1871)
  check if arrow build dir exists (ray-project#1863)
  [DataFrame] Encapsulate index and lengths into separate class (ray-project#1849)
  [DataFrame] Implemented __getattr__ (ray-project#1753)
  Add better analytics to docs (ray-project#1854)
  ...

# Conflicts:
#	python/ray/rllib/__init__.py
#	python/setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elibol @AmplabJenkins @pcmoritz