Skip to content

[DataFrame] Inherit documentation from Pandas#1727

Merged
devin-petersohn merged 9 commits intoray-project:masterfrom
pschafhalter:dataframe-doc
Apr 13, 2018
Merged

[DataFrame] Inherit documentation from Pandas#1727
devin-petersohn merged 9 commits intoray-project:masterfrom
pschafhalter:dataframe-doc

Conversation

@pschafhalter
Copy link
Copy Markdown
Contributor

@pschafhalter pschafhalter commented Mar 16, 2018

What do these changes do?

Ray DataFrame class inherits documentation from identical methods present in the Pandas DataFrame class.

Note that Ray DataFrame does not inherit documentation for itself or DataFrame.__init__. Currently, these have different definitions. This will need to be changed once the __init__ is the same for Ray and Pandas dataframes.

devin-petersohn
devin-petersohn reviewed Mar 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@devin-petersohn devin-petersohn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for checking that this works?

Edit: I see them, forgive my blindness.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 16, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4363/
Test PASSed.

@pschafhalter
Copy link
Copy Markdown
Contributor Author

pschafhalter commented Mar 17, 2018

@devin-petersohn Should I replace the hasattr with a try/except? Looks like there's issues with hasattr in python2.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 17, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4366/
Test PASSed.

@devin-petersohn
Copy link
Copy Markdown
Member

devin-petersohn commented Mar 19, 2018

@pschafhalter Yes, it's probably best for now.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Mar 19, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4403/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 6, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4695/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 6, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4696/
Test PASSed.

kunalgosar
kunalgosar suggested changes Apr 6, 2018
View reviewed changes
python/ray/dataframe/dataframe.py Outdated
Copy link
Copy Markdown
Contributor

@kunalgosar kunalgosar Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used on other Dataframe related classes (e.g. DataFrameGroupBy)

Copy link
Copy Markdown
Contributor Author

@pschafhalter pschafhalter Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added decorator Series and DataFrameGroupBy. We should make a note somewhere to override documentation for future Pandas classes that we implement.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 8, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4740/
Test PASSed.

@devin-petersohn
Copy link
Copy Markdown
Member

devin-petersohn commented Apr 10, 2018

@pschafhalter This has some compatibility issues with Python2, could you clear those up and ping me when they're fixed?

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 12, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4830/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 12, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4832/
Test PASSed.

@pschafhalter
Copy link
Copy Markdown
Contributor Author

pschafhalter commented Apr 13, 2018

@devin-petersohn it should be fixed for python 2 now

@devin-petersohn devin-petersohn merged commit 1d605e8 into ray-project:master Apr 13, 2018
@devin-petersohn
Copy link
Copy Markdown
Member

devin-petersohn commented Apr 13, 2018

Thanks @pschafhalter!

@pschafhalter pschafhalter deleted the dataframe-doc branch April 20, 2018 20:49
royf added a commit to royf/ray that referenced this pull request Apr 22, 2018
@royf
Merge branch 'master' into softq
40ed3a0 
* master: (56 commits)
  [xray] Turn on flushing to the GCS for the lineage cache (ray-project#1907)
  Single Big Object Parallel Transfer. (ray-project#1827)
  Remove num_threads as a parameter. (ray-project#1891)
  Adds Valgrind tests for multi-threaded object manager. (ray-project#1890)
  Pin cython version in docker base dependencies file. (ray-project#1898)
  Update arrow to efficiently serialize more types of numpy arrays. (ray-project#1889)
  updates (ray-project#1896)
  [DataFrame] Inherit documentation from Pandas (ray-project#1727)
  Update arrow and parquet-cpp. (ray-project#1875)
  raylet command line resource configuration plumbing (ray-project#1882)
  use raylet for remote ray nodes (ray-project#1880)
  [rllib] Propagate dim option to deepmind wrappers (ray-project#1876)
  [RLLib] DDPG (ray-project#1685)
  Lint Python files with Yapf (ray-project#1872)
  [DataFrame] Fixed repr, info, and memory_usage (ray-project#1874)
  Fix getattr compat (ray-project#1871)
  check if arrow build dir exists (ray-project#1863)
  [DataFrame] Encapsulate index and lengths into separate class (ray-project#1849)
  [DataFrame] Implemented __getattr__ (ray-project#1753)
  Add better analytics to docs (ray-project#1854)
  ...

# Conflicts:
#	python/ray/rllib/__init__.py
#	python/setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

+1 more reviewer

@kunalgosar kunalgosar kunalgosar requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pschafhalter @AmplabJenkins @devin-petersohn @kunalgosar