[autoscaler] remove worker_default_node_type that is useless.#13588
[autoscaler] remove worker_default_node_type that is useless.#13588ericl merged 110 commits intoray-project:masterfrom AmeerHajAli:yaml
Conversation
This reverts commit 818a63a.
|
Took out everything involving "workerDefaultPodType" from operator-related things and a stray line involving "worker_default_node_type" from "rewrite_legacy_yaml_to_available_node_types". LGTM -- just need to take another look at test output once CI is done. |
|
@ericl , please merge. |
|
This is a backwards-incompatible change. (Ex: user must remove this field in their existing cluster configs after they upgrade to a version of ray with this change) @AmeerHajAli, @ericl, Will this be a major version change? |
|
Could we just remove the field from all examples and make it optional?
(since it does nothing anyways?)
Eric
…On Thu, Jan 21, 2021 at 6:16 PM Alan Guo ***@***.***> wrote:
This is a backwards-incompatible change. (Ex: user must remove this field
in their existing cluster configs after they upgrade to a version of ray
with this change)
@AmeerHajAli <https://github.com/AmeerHajAli>, @ericl
<https://github.com/ericl>,
I'd like to get a better understanding of the compatibility guarantees of
the cluster config and ray in general.
Will this be a major version change?
Will there be migration instructions in the change logs?
Should the field be marked as deprecated first before deleting?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13588 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSVAM5TRDDQ6KVAPFUTS3DNXJANCNFSM4WLHYQ2A>
.
|
Trying on GKE version : 1.17.14-gke.400 1. @AmeerHajAli @DmitriGekhtman +1 on this. Getting this error 2. Additionally, When I try 2 weeks old yamls( via my fork : https://github.com/paravatha/ray) NAME READY STATUS RESTARTS AGE |
|
Switched to rayproject/ray:latest, but seeing the same issue Normal Scheduled 89s default-scheduler Successfully assigned ray/ray-operator-pod to gke-ray-cluster-default-pool-938c5c6a-71c1 |
|
Hi @paravatha -- we'll be more careful with backwards-incompatible changes. Temporarily, what can be done is to use an image built from the last commit before this PR was merged: More info on Docker source images here: https://docs.ray.io/en/master/installation.html#docker-source-images |
|
@DmitriGekhtman , is the issue still there despite this fix? |
|
@AmeerHajAli |
…ray-project#13588)" This reverts commit 773d13c.
the field is not used anywhere.
Checks
scripts/format.shto lint the changes in this PR.