[kubernetes][operator][hotfix] Dictionary fix#13663
Merged
edoakes merged 1 commit intoray-project:masterfrom Jan 25, 2021
Merged
[kubernetes][operator][hotfix] Dictionary fix#13663edoakes merged 1 commit intoray-project:masterfrom
edoakes merged 1 commit intoray-project:masterfrom
Conversation
|
I assume this PR will resolve #13667 |
|
Instead of the operator panicking if there is a Python exception, shouldn't the operator update status of |
Contributor
Author
Yes -- updated this PR's description to reflect that.
You're right, thanks. I'll open an issue for that. |
This was referenced Jan 24, 2021
edoakes
approved these changes
Jan 25, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
)" This reverts commit b5c4568.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#13623 causes a key error when launching the operator --
Error comes from the fact that the head pod's config doesn't have the optional minWorkers.
(Don't know how I missed this before -- probably screwed up tests when checking #13623.)
This PR fixes the problem by iterating only over the keys belong to both of the relevant dictionaries.
A key error from the
translatemethod is no longer possible.Related issue number
Closes #13667 .
Checks
scripts/format.shto lint the changes in this PR.I'm pretty sure I ran the test right this time --
built an image incorporating the changes,
ran a container based on the image and checked that the code changes were present in the ray installed there, ran the operator unit test,
checked that the operator pod was using the right image.