[Serve] Refactor BackendState#13406
Merged
edoakes merged 21 commits intoray-project:masterfrom Jan 21, 2021
Merged
Conversation
edoakes
reviewed
Jan 19, 2021
edoakes
reviewed
Jan 20, 2021
ijrsvt
commented
Jan 20, 2021
ijrsvt
commented
Jan 20, 2021
Comment on lines
166
to
167
| self._state = ReplicaState.STOPPED | ||
| return True |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| self._state = ReplicaState.STOPPED | |
| return True | |
| # The next call to `check_stopped` will return True on the `get_actor` call. | |
| return False |
Contributor
Author
There was a problem hiding this comment.
we should not transition the replica to "STOPPED" here because we probably want to repeatedly log and send the kill request until the replica actually exits
cc @edoakes
edoakes
reviewed
Jan 20, 2021
ijrsvt
commented
Jan 21, 2021
edoakes
approved these changes
Jan 21, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…y-project#13406)" This reverts commit fc37933.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #13155
Checks
scripts/format.shto lint the changes in this PR.