Skip to content

[serve] Count pending replicas#13155

Closed
ijrsvt wants to merge 3 commits intoray-project:masterfrom
ijrsvt:fix-current-num-replicas
Closed

[serve] Count pending replicas#13155
ijrsvt wants to merge 3 commits intoray-project:masterfrom
ijrsvt:fix-current-num-replicas

Conversation

@ijrsvt
Copy link
Copy Markdown
Contributor

@ijrsvt ijrsvt commented Jan 3, 2021

Why are these changes needed?

  • The number of current replicas should be equal to:
NUM_CURRENT + NUM_STARTING - NUM_STOPPING

Related issue number

Closes #12929

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt force-pushed the fix-current-num-replicas branch from e7c99bb to 61a5699 Compare January 6, 2021 00:18
@ijrsvt ijrsvt assigned edoakes and unassigned edoakes Jan 8, 2021
Copy link
Copy Markdown
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jan 8, 2021

@ijrsvt actually, could you also please add a regression test for this?

@ijrsvt ijrsvt mentioned this pull request Jan 13, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[serve] Prefer stopping pending replicas instead of running ones

2 participants