Update conda recipes for Enhanced Compatibility effort#893
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-21.12from Nov 4, 2021
Merged
Update conda recipes for Enhanced Compatibility effort#893rapids-bot[bot] merged 8 commits intorapidsai:branch-21.12from
conda recipes for Enhanced Compatibility effort#893rapids-bot[bot] merged 8 commits intorapidsai:branch-21.12from
Conversation
Member
Author
|
rerun tests |
1 similar comment
Member
Author
|
rerun tests |
Member
Author
|
Depends on #901. Keeping as a draft until that is complete. We'll probably see lots of failures until that PR is merged. |
fa82573 to
c6498fa
Compare
c6498fa to
b95ccae
Compare
`conda` seems to only build multiple variants if the variant key is explicity used in the recipe. (i.e. not via Jinja)
Member
Author
|
rerun tests |
jjacobelli
approved these changes
Nov 3, 2021
Member
Author
|
After reviewing the CI logs, it seems that these changes are working correctly. |
Member
Author
|
@gpucibot merge |
jakirkham
reviewed
Nov 4, 2021
| - numba >=0.49 | ||
| - numpy | ||
| - {{ pin_compatible('cudatoolkit', max_pin='x.x') }} | ||
| - {{ pin_compatible('cudatoolkit', max_pin='x', min_pin='x') }} |
Member
There was a problem hiding this comment.
In conda-forge we decided that the min_pin should be x.x. Please see comment ( conda-forge/nvcc-feedstock#71 (comment) ) and subsequent discussion for context.
Member
Author
There was a problem hiding this comment.
Hmm. I'm confused how this would work? If we set min_pin to x.x, then wouldn't our pins effectively become cudatoolkit>=11.5,<12? How would this work for users that use cudatoolkit=11.{0,2,4}?
This is all assuming that we're only going to build packages with CUDA 11.5, which is what I thought the plan was, no?
ajschmidt8
added a commit
to ajschmidt8/rmm
that referenced
this pull request
Nov 5, 2021
After merging rapidsai#893, there are now 2 `librmm` `conda` packages being published instead of 1. Therefore the upload script needs to be updated accordingly. Skipping CI since the upload script isn't run on PRs anyway.
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2021
After merging #893, there are now 2 `librmm` `conda` packages being published instead of 1. Therefore the upload script needs to be updated accordingly. Skipping CI since the upload script isn't run on PRs anyway. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: #909
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2021
This PR tweaks the changes from #893 and #909 so that `rmm` produces two packages (`has_cma` and `no_cma`) instead of `librmm`. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: #910
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
condarecipe build strings andcudatoolkitversion specifications as part of the Enhanced Compatibility efforts.rmmChangesThe build strings in the
condarecipe have been updated to only include the major CUDA version (i.e.librmm-21.12.00a-cuda11_gc781527_12.tar.bz2) and thecudatoolkitversion specifications will now be formatted likecudatoolkit >=x,<y.0a0(i.e.cudatoolkit >=11,<12.0a0).Moving forward, we'll build the packages with a single CUDA version (i.e.
11.5) and test them in environments with different CUDA versions (i.e.11.0,11.2,11.4, etc.).librmmChangesA
conda_build_config.yamlfile has been added to thelibrmmrecipe folder so that two variants oflibrmmare built: one with and one withoutcudaMallocAsyncsupport. A new environment variable,BUILD_FLAGS, is passed through toconda/recipes/librmm/build.shand is set according to thecudaMallocAsyncvariant value in the recipe. Finally, a build string modifier of eitherno_cmaorhas_cmais appended to the build string which is used to determine which package should be installed inci/gpu/build.sh.