Update recipes for Enhanced Compatibility#910
Update recipes for Enhanced Compatibility#910rapids-bot[bot] merged 5 commits intorapidsai:branch-21.12from
Conversation
jakirkham
left a comment
There was a problem hiding this comment.
Variables specified in conda_build_config.yaml (like cudaMallocAsync) can be used as environment variables, which may simplify things here
Thanks @jakirkham! Testing your suggestions locally real quick and then I will commit them. |
|
Requires more changes. Switching to |
|
rerun tests |
This reverts commit e9aefba.
| build: | ||
| number: {{ GIT_DESCRIBE_NUMBER }} | ||
| string: cuda_{{ cuda_major }}_py{{ py_version }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }} | ||
| string: cuda{{ cuda_major }}_py{{ py_version }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }}_{{ cudaMallocAsync }} |
There was a problem hiding this comment.
Is the cudaMallocAsync bit still needed here given the changes above and the fact it is implicit based on CUDA version?
There was a problem hiding this comment.
We have some logic below that depends on this extra metadata in the build string. If you know a way we can work around that, then we could remove the extra {{ cudaMallocAsync }} bit here.
Lines 116 to 123 in 76ae622
|
@gpucibot merge |
This PR tweaks the changes from #893 and #909 so that
rmmproduces two packages (has_cmaandno_cma) instead oflibrmm.