This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Update IO anchor to correct link in user guide#1154
Closed
taureandyernv wants to merge 1 commit intorapidsai:branch-23.06from
Closed
Update IO anchor to correct link in user guide#1154taureandyernv wants to merge 1 commit intorapidsai:branch-23.06from
taureandyernv wants to merge 1 commit intorapidsai:branch-23.06from
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
isVoid
approved these changes
May 25, 2023
Contributor
|
@taureandyernv Thanks for the fix! |
thomcom
approved these changes
May 25, 2023
Contributor
|
CI failure is caused by upstream changes to cudf which #1151 is intended to fix. How do we force-merge? This is one of two fixes so that 1151 can be merged, though we should probably just force merge it as well since it is blocking all cuspatial CI. |
Contributor
Would probably need @ajschmidt8 to help admin merge here. |
Contributor
|
To avoid the admin-merge, I merged this small change into #1151. That PR needed to rerun tests anyway for a new cuml nightly. |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Update `cudf::column` constructor args to match the changes in rapidsai/cudf#13341. Also corrects a minor issue in the docs, closes #1154. Authors: - Paul Taylor (https://github.com/trxcllnt) - Taurean Dyer (https://github.com/taureandyernv) - Bradley Dice (https://github.com/bdice) Approvers: - Michael Wang (https://github.com/isVoid) - Mark Harris (https://github.com/harrism) URL: #1151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The user guide has an incorrect anchor link for the Input/Output section, which threw breaking warnings in CI. this should correct it.
Checklist