This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Fix cudf::column constructor args#1151
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-23.06from May 26, 2023
Merged
Fix cudf::column constructor args#1151rapids-bot[bot] merged 5 commits intorapidsai:branch-23.06from
cudf::column constructor args#1151rapids-bot[bot] merged 5 commits intorapidsai:branch-23.06from
Conversation
isVoid
approved these changes
May 23, 2023
Contributor
Author
|
Failing test seems like an unrelated cuML bug. |
harrism
approved these changes
May 23, 2023
Contributor
Tracked by: rapidsai/cuml#5434 |
Member
|
How do we rerun tests? Is the cuML fix in last night's nightly? |
Member
FIgured this out. Click on failing action, look for rerun icon in top right (circular arrows). |
3 tasks
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
/merge |
Contributor
|
I went ahead and merged this since it fixes nightlies, which are needed for 23.06 release testing. cc: @beckernick this should be good to go once builds finish on the merge commit and are pushed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
cudf::columnconstructor args to match the changes in rapidsai/cudf#13341.Also corrects a minor issue in the docs, closes #1154.
Checklist