This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Add segment Iterators, test multi*_range and miscellaneous lazy iterator additions#1026
Merged
rapids-bot[bot] merged 21 commits intorapidsai:branch-23.04from Apr 5, 2023
Merged
Conversation
isVoid
commented
Mar 31, 2023
cpp/include/cuspatial/experimental/detail/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
isVoid
commented
Mar 31, 2023
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
isVoid
commented
Apr 1, 2023
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Show resolved
Hide resolved
isVoid
commented
Apr 1, 2023
isVoid
commented
Apr 1, 2023
isVoid
commented
Apr 1, 2023
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Show resolved
Hide resolved
…al into feature/segment_iterators
3 tasks
harrism
suggested changes
Apr 4, 2023
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
trxcllnt
approved these changes
Apr 5, 2023
trxcllnt
reviewed
Apr 5, 2023
trxcllnt
reviewed
Apr 5, 2023
trxcllnt
reviewed
Apr 5, 2023
harrism
approved these changes
Apr 5, 2023
…al into feature/segment_iterators
Contributor
Author
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
This PR adds `linestring-polygon` distance API. This API divides up the work into two parts: point-in-polygon test and a load-balanced all-pairs segment-segment distance compute kernel. Closes #1027 Depends on #1026 Contributes to #757 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #1011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #1025
This PR adds RAI segment iterators to
multilinestring_rangeandmultipolygon_range.Caveats: this iterator currently will fail if the range contains empty geometries (such as an empty linestring or an empty polygon).
Usage example:
This PR also adds a few helper methods that will be used in
pairwise_linestring_polygon_distanceAPI. All of them are tested. Contributes to #991Checklist