Closed
Conversation
Contributor
Author
|
@rafaelfranca sorry to trouble you again, I fix this but changed it's behavior, please check. |
Contributor
Author
|
@vad4msiu seems no one attention this |
Contributor
There was a problem hiding this comment.
This is supposed to be specified_primary_key.
Member
|
counter_cache still increases twice when association would be updated. |
|
Same problem here, tried with 4.2.1 and 4.2.3. |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Sep 18, 2018
This is a 4th attempt to make counter cache transactional completely. Past attempts: rails#9236, rails#14849, rails#23357. All existing counter cache issues (increment/decrement twice, lost increment) are caused due to updating counter cache on the outside of the record saving transaction by assigning belongs_to record, even though assigning that doesn't cause the record saving. We have the `@_after_replace_counter_called` guard condition to mitigate double increment/decrement issues, but we can't completely prevent that inconsistency as long as updating counter cache on the outside of the transaction, since saving the record is not always happened after that. We already have handling counter cache after create/update/destroy, https://github.com/rails/rails/blob/1b90f614b1b3d06b7f02a8b9ea6cd84f15d58643/activerecord/lib/active_record/counter_cache.rb#L162-L189 https://github.com/rails/rails/blob/1b90f614b1b3d06b7f02a8b9ea6cd84f15d58643/activerecord/lib/active_record/associations/builder/belongs_to.rb#L33-L59 so just removing assigning logic on the belongs_to association makes counter cache transactional completely. Closes rails#14849. Closes rails#23357. Closes rails#31493. Closes rails#31494. Closes rails#32372. Closes rails#33113. Closes rails#33117 Closes rails#33129. Closes rails#33458.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I update behavior of
counter_cache, the reason has described at #8997.