Keep attribute change in increment! when record is not persisted#33458
Keep attribute change in increment! when record is not persisted#33458al3rez wants to merge 1 commit intorails:masterfrom
increment! when record is not persisted#33458Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
018e546 to
0457858
Compare
What? When `counter_cache` and `accepts_nested_attributes_for` defined and updating parent object through belonging object, the actual counter cache database column doesn't get persisted. How? Added a guard to prevent `clear_attribute_change` occur when record persisted in `increment!`. Use double-quotes Remove debugging info.
0457858 to
6f6a9e4
Compare
|
@pixeltrix Would you please take a look at this PR. |
|
@kamipo Would you do the honor? |
This is a 4th attempt to make counter cache transactional completely. Past attempts: rails#9236, rails#14849, rails#23357. All existing counter cache issues (increment/decrement twice, lost increment) are caused due to updating counter cache on the outside of the record saving transaction by assigning belongs_to record, even though assigning that doesn't cause the record saving. We have the `@_after_replace_counter_called` guard condition to mitigate double increment/decrement issues, but we can't completely prevent that inconsistency as long as updating counter cache on the outside of the transaction, since saving the record is not always happened after that. We already have handling counter cache after create/update/destroy, https://github.com/rails/rails/blob/1b90f614b1b3d06b7f02a8b9ea6cd84f15d58643/activerecord/lib/active_record/counter_cache.rb#L162-L189 https://github.com/rails/rails/blob/1b90f614b1b3d06b7f02a8b9ea6cd84f15d58643/activerecord/lib/active_record/associations/builder/belongs_to.rb#L33-L59 so just removing assigning logic on the belongs_to association makes counter cache transactional completely. Closes rails#14849. Closes rails#23357. Closes rails#31493. Closes rails#31494. Closes rails#32372. Closes rails#33113. Closes rails#33117 Closes rails#33129. Closes rails#33458.
What?
Fixes #33113 - When
counter_cacheandaccepts_nested_attributes_fordefined and updatingparent object through belonging object, the actual counter cache database
column doesn't get persisted.
How?
Added a guard to prevent
clear_attribute_changeoccur when record persistedin
increment!.