Skip to content

Tweak Gemfile comment about Solid adapters#52925

Merged
dhh merged 1 commit intorails:mainfrom
jeromedalbert:gemfile-solid-adapters-comment
Sep 14, 2024
Merged

Tweak Gemfile comment about Solid adapters#52925
dhh merged 1 commit intorails:mainfrom
jeromedalbert:gemfile-solid-adapters-comment

Conversation

@jeromedalbert
Copy link
Contributor

Follow-up to 1ec7b1970f8.

Do not mention Action Cable in the Gemfile if the app was generated with --skip-action-cable.

Do not mention Action Cable if app was generated with
--skip-action-cable
@jeromedalbert jeromedalbert force-pushed the gemfile-solid-adapters-comment branch from 9322990 to 14e1a53 Compare September 14, 2024 06:35
@dhh dhh merged commit 0c54183 into rails:main Sep 14, 2024
dhh added a commit that referenced this pull request Sep 14, 2024
* main:
  Tweak Gemfile comment about Solid adapters (#52925)
  Do not set up cable DB if skipping action cable (#52923)
  Fixup enum schema methods' signature to accept kwargs
  Add if_not_exists option to add_enum_value
@jeromedalbert jeromedalbert deleted the gemfile-solid-adapters-comment branch September 14, 2024 19:10
DanielaVelasquez pushed a commit to DanielaVelasquez/rails that referenced this pull request Oct 3, 2024
Do not mention Action Cable if app was generated with
--skip-action-cable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants