Do not set up cable database when skipping action cable#52923
Merged
dhh merged 1 commit intorails:mainfrom Sep 14, 2024
Merged
Conversation
When creating a new rails app with the `--skip-action-cable` option, the generated `database.yml` should not set up the `cable` database.
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
When creating a new rails app with the `--skip-action-cable` option, the generated `database.yml` should not set up the `cable` database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52889 and #52919.
Motivation / Background
This Pull Request has been created because if you currently create a new Rails Main app with the
--skip-action-cableoption, the generateddatabase.ymlsets up acabledatabase for the production environment.Steps to repro the issue:
rails new myapp --main --skip-action-cable; cd myappdatabase.ymldoes not set up acabledatabase.database.ymlsets up acabledatabase:Detail
This Pull Request changes the database
.yml.tttemplates to not set up thecabledatabase when the--skip-action-cableis provided.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]