Skip to content

Document apply_rubocop_autocorrect_after_generate! in configuration guide [skip ci]#50532

Merged
dhh merged 1 commit intorails:mainfrom
akhilgkrishnan:document-rubocop-autofix-in-generator
Jan 2, 2024
Merged

Document apply_rubocop_autocorrect_after_generate! in configuration guide [skip ci]#50532
dhh merged 1 commit intorails:mainfrom
akhilgkrishnan:document-rubocop-autofix-in-generator

Conversation

@akhilgkrishnan
Copy link
Member

@akhilgkrishnan akhilgkrishnan commented Jan 2, 2024

Motivation / Background

#50506 Added a new configuration method apply_rubocop_autocorrect_after_generate! for applying the rubocop autocorrection on files generated by bin/rails generate.

Detail

This Pull Request adds the document apply_rubocop_autocorrect_after_generate! in the configuration guide.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Jan 2, 2024
koic
koic reviewed Jan 2, 2024
View reviewed changes
@akhilgkrishnan akhilgkrishnan force-pushed the document-rubocop-autofix-in-generator branch from c4e6c7d to 9c77909 Compare January 2, 2024 07:11
@dhh dhh merged commit 65f4022 into rails:main Jan 2, 2024
dhh added a commit that referenced this pull request Jan 2, 2024
@dhh
Merge branch 'main' into pwa-files
12b93f6 
* main:
  Fix test
  Allow overriding SQLite defaults from `database.yml` (#50460)
  Fix a flaky test in `query_assertions_test.rb` (#50503)
  Document apply_rubocop_autocorrect_after_generate! in configuration guide (#50532)
  bundle update rubocop --conservative (#50515)
yoones pushed a commit to yoones/rails that referenced this pull request Mar 6, 2025
@akhilgkrishnan @yoones
Document apply_rubocop_autocorrect_after_generate! in configuration g…
23815b5 
…uide (rails#50532)

Update requested change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@koic koic koic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhilgkrishnan @koic @dhh