Fix a flaky test in query_assertions_test.rb#50503
Merged
dhh merged 1 commit intorails:mainfrom Jan 2, 2024
Merged
Conversation
8733df3 to
15a00c7
Compare
Member
Author
|
Additionally fixed another similar flaky test - https://buildkite.com/rails/rails/builds/103109#018cc0e2-6170-4743-b8b6-e86765d64361 |
yoones
pushed a commit
to yoones/rails
that referenced
this pull request
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test from https://buildkite.com/rails/rails/builds/103104#018cbef2-ddda-4c0d-b30d-70d5d55cff93
To reproduce:
I wasn't able to reduce it and to find the exact preceding test case that makes this test to fail. Seems like somewhere the connection is reset/etc and so is reestablished in this test case and thus generates extra queries.
Changing this test case to be less strict makes it pass.