Sets default mailer queue to default#40848
Merged
rafaelfranca merged 1 commit intorails:masterfrom Dec 18, 2020
Merged
Conversation
Contributor
Author
|
@rafaelfranca please check, this extends your previous pull request #40766 /cc @georgeclaghorn |
pftg
commented
Dec 15, 2020
d63bded to
d8513d9
Compare
Contributor
Author
|
@kamipo could you check this |
rafaelfranca
requested changes
Dec 16, 2020
20f8c31 to
e2fbb43
Compare
772cd47 to
934f097
Compare
Contributor
Author
|
@rafaelfranca thanks for the review, added updates. Removed unrelated issues, will finish them in separate PR |
pftg
commented
Dec 17, 2020
d13f8e8 to
8896fb7
Compare
Use "default" as default queue for mailers test helpers
8896fb7 to
7d7bd2b
Compare
Contributor
Author
|
@rafaelfranca thanks for the feedback (you prevented many problems). I added updates. Please check when you will have time. |
rafaelfranca
approved these changes
Dec 18, 2020
rafaelfranca
added a commit
that referenced
this pull request
Dec 18, 2020
…rt_enqueued_email_with_as_default Sets default mailer queue to default
tagliala
added a commit
to tagliala/rails
that referenced
this pull request
Mar 5, 2021
The default queue name used by `deliver_later` is no longer `mailers`. This commit removes the misleading information from the class documentation Ref: rails#40848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #40846