Change default queue name of all the internal jobs to be the job adapter's default#40766
Merged
rafaelfranca merged 1 commit intorails:6-1-stablefrom Dec 8, 2020
Merged
Conversation
…ter's default `config.active_storage.queues.analysis`: From `:active_storage_analysis` to `nil`. `config.active_storage.queues.purge`: From `:active_storage_purge` to `nil`. `config.action_mailbox.queues.incineration`: From `:action_mailbox_incineration` to `nil`. `config.action_mailbox.queues.routing`: From `:action_mailbox_routing` to `nil`. `config.action_mailer.deliver_later_queue_name`: From `:mailers` to `nil`. Fixes rails#40730.
Member
Author
|
I'll forwardport those changes to master, but since the of the most important changes are in the |
georgeclaghorn
approved these changes
Dec 8, 2020
rafaelfranca
added a commit
that referenced
this pull request
Dec 8, 2020
Change default queue name of all the internal jobs to be the job adapter's default
abhaynikam
added a commit
to abhaynikam/rails
that referenced
this pull request
Dec 9, 2020
Contributor
|
The default should probably be changed in test helpers too, I had to fix tests to manually specify |
Contributor
|
added issue and fixing #40846 |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jan 4, 2021
Follow-up to rails#40766. This commit adds a few missing values to the "Baseline defaults" section, and removes mention of default values elsewhere to prevent confusion due to overloaded defaults.
filipegiusti
reviewed
Apr 8, 2021
Comment on lines
+62
to
+63
| # Set the default queue name for the mail deliver job to the queue adapter default. | ||
| # Rails.application.config.action_mailer.deliver_later_queue_name = nil |
There was a problem hiding this comment.
Apparently this should be
ActionMailer::Base.deliver_later_queue_name = nilbecause as said in #39810 "Since your initializer is only loaded after the framework, setting config.action_mailer.deliver_later_queue_name will not have any effect."
I tried to create a PR but I don't know which branch/tag I should start on to make a change for this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.active_storage.queues.analysis:From
:active_storage_analysistonil.config.active_storage.queues.purge:From
:active_storage_purgetonil.config.action_mailbox.queues.incineration:From
:action_mailbox_incinerationtonil.config.action_mailbox.queues.routing:From
:action_mailbox_routingtonil.config.action_mailer.deliver_later_queue_name:From
:mailerstonil.Fixes #40730.
cc @mperham