Deflator option to enable custom ones like zstd#2399
Merged
ioquatix merged 1 commit intoOct 31, 2025
Conversation
jeremyevans
approved these changes
Oct 23, 2025
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
Still looks good, one minor simplification recommended.
0cf3206 to
31416dc
Compare
rafaelfranca
approved these changes
Oct 23, 2025
ioquatix
requested changes
Oct 24, 2025
ioquatix
left a comment
Member
There was a problem hiding this comment.
Please update the changelog.
See also Jeremy's comment in the issue: rack#2168 (comment) Basic usage with Zstd (https://github.com/SpringMT/zstd-ruby) use Rack::Deflater, deflaters: { "zstd" => lambda { |headers, body| ZstdStream.new(body) } } Multiple custom deflaters: use Rack::Deflater, deflaters: { "zstd" => zstd_deflater, "br" => brotli_deflater } refs rack#2168
31416dc to
1965f18
Compare
Contributor
Author
|
ah, right. ✔️ |
ioquatix
reviewed
Oct 24, 2025
ioquatix
approved these changes
Oct 31, 2025
ioquatix
pushed a commit
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deleted my fork by accident and therefore I closed #2393 🫣
Here it is again:
Hi folks,
I hope that it is okay that I gave it a try? 🫣
Basically this is how I understood Jeremy's comment in the issue 2168.
The basic usage with Zstd would be
Thank you so much for maintaining Rack! 🙏
PS: I'm looking for a new adventure in case anybody is looking to hire someone or in case someone would like to work with a Ruby/Rails/Crystal dev