option for custom deflaters#2393
Closed
alexanderadam wants to merge 1 commit into
Closed
Conversation
jeremyevans
reviewed
Oct 14, 2025
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this.
Contributor
Author
|
Thank you so much for the fast feedback! 🙏 |
jeremyevans
reviewed
Oct 15, 2025
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just have a few minor tweaks requested.
See also Jeremy's comment in the issue: #2168 (comment) Basic usage with Zstd (https://github.com/SpringMT/zstd-ruby) use Rack::Deflater, deflaters: { "zstd" => lambda { |headers, body| ZstdStream.new(body) } } Multiple custom deflaters: use Rack::Deflater, deflaters: { "zstd" => zstd_deflater, "br" => brotli_deflater } refs #2168
Contributor
Author
|
Thank you for your feedback. I'm not used to get feedback so quickly. That's wonderfully refreshing 🙏 |
jeremyevans
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: I deleted my fork again and this action closed this PR here. I created PR #2399. Sorry for the inconvenience.
Hi folks,
I hope that it is open that I gave it a try? 🫣
Basically this is how I understood Jeremy's comment in the issue 2168.
The basic usage with Zstd would be
Thank you so much for maintaining Rack! 🙏