Skip to content

Add multi mapping support via header#1187

Merged
tenderlove merged 1 commit into
rack:masterfrom
yoshuki:multiple-accel-mapping
Aug 10, 2017
Merged

Add multi mapping support via header#1187
tenderlove merged 1 commit into
rack:masterfrom
yoshuki:multiple-accel-mapping

Conversation

@yoshuki

@yoshuki yoshuki commented Jul 3, 2017

Copy link
Copy Markdown
Contributor

nignx sets "HTTP_X_ACCEL_MAPPING" from multi mappings to comma splited string.
like,

proxy_set_header X-Accel-Mapping /var/www1/=/files1/;
proxy_set_header X-Accel-Mapping /var/www2/=/files2/;

to

'/var/www1/=/files1/, /var/www2/=/files2/'

@tenderlove tenderlove merged commit cb00d24 into rack:master Aug 10, 2017
@firien

firien commented Sep 25, 2018

Copy link
Copy Markdown

altagem pushed a commit to altagem/rack that referenced this pull request Nov 21, 2018
We need to support multiple mappings for X-Accel-Mapping nginx header. The original
PR on the original repo ([PR rack#1187](https://github.com/rack/rack/pull/1187/files))
has been merged onto master but not released yet.
@nbibler

nbibler commented Nov 26, 2018

Copy link
Copy Markdown

Seemingly this duplicates #853, although it uses commas instead of semicolons for the separator. I guess the other PR should be closed?

@pabuisson

Copy link
Copy Markdown

Those two PRs are really similar indeed. I also think PR #853 could then be closed since the current PR we're commenting on has already been merged into master.

@aidewoode

Copy link
Copy Markdown

I'm wondering why don't release it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants