Add support for multiple, semicolon-separated X-Accel-Mappings#853
Closed
nbibler wants to merge 1 commit into
Closed
Add support for multiple, semicolon-separated X-Accel-Mappings#853nbibler wants to merge 1 commit into
nbibler wants to merge 1 commit into
Conversation
|
+1 on this! |
Author
|
Closing this PR since #1187 meets the need (although uses a slightly different data structure). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the header-defined mapping functionality to match that of the explicitly-instantiated mappings.
In all current versions of
Rack::Sendfile, a developer may define multiple mappings if they instantiate Sendfile with an Array of mappings. The ability to define multiple mappings is unavailable, however, when parsing the request environment'sX-Accel-Mappingheader.This pull request introduces the ability to define multiple mappings in the
X-Accel-Mappingrequest header.