CLI: handle {:relative, val} cases when formatting effective memory watermark value#2965
Merged
michaelklishin merged 4 commits intomasterfrom Apr 10, 2021
Merged
CLI: handle {:relative, val} cases when formatting effective memory watermark value#2965michaelklishin merged 4 commits intomasterfrom
michaelklishin merged 4 commits intomasterfrom
Conversation
It can be exposed to CLI tools when relative watermark value is configured via advanced.config. Closes #2964.
High VM memory watermark cannot actually be set to 'infinity' (and beyond :P) but it can be returned as a fallback value. See #2733 for some additional context. We format 'infinity' as "100% of available memory". This seems to be a reasonable way to do it because the status command will try to present a final interpreted limit value. Generally a limit of infinity won't be returned except very early in node boot when the monitor(s) haven't yet started. Per discussion with @evaskova.
to be extra defensive. We never supported it [1] but some try to use it by analogy to the high VM watermark value [in advanced.config] References #2964. 1. https://github.com/rabbitmq/rabbitmq-server/blob/v3.6.x/docs/rabbitmq.config.example#L306-L320
michaelklishin
added a commit
that referenced
this pull request
Apr 10, 2021
CLI: handle {:relative, val} cases when formatting effective memory watermark value
(cherry picked from commit 0a48a2a)
Collaborator
Author
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
CLI: handle
{:relative, val}cases when formatting effective memory watermark value.It can be exposed to CLI tools when relative watermark value is
configured via advanced.config.
I fixed a couple of tiny related things discovered along the way.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
Closes #2964.