'get_memory_use(ratio)' will have an exception when MemoryLimit is 'infinity'#2733
Merged
michaelklishin merged 1 commit intorabbitmq:masterfrom Jan 21, 2021
tomyouyou:vm_memuse
Merged
'get_memory_use(ratio)' will have an exception when MemoryLimit is 'infinity'#2733michaelklishin merged 1 commit intorabbitmq:masterfrom tomyouyou:vm_memuse
michaelklishin merged 1 commit intorabbitmq:masterfrom
tomyouyou:vm_memuse
Conversation
Collaborator
|
For those curious how this is possible given the |
Contributor
Author
|
michaelklishin
added a commit
that referenced
this pull request
Jan 21, 2021
Collaborator
|
This will be back ported for |
Collaborator
|
Backported to |
michaelklishin
added a commit
that referenced
this pull request
Apr 10, 2021
High VM memory watermark cannot actually be set to 'infinity' (and beyond :P) but it can be returned as a fallback value. See #2733 for some additional context. We format 'infinity' as "100% of available memory". This seems to be a reasonable way to do it because the status command will try to present a final interpreted limit value. Generally a limit of infinity won't be returned except very early in node boot when the monitor(s) haven't yet started. Per discussion with @evaskova.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nfinity'
Proposed Changes
Please describe the big picture of your changes here to communicate to the
RabbitMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.
A pull request that doesn't explain why the change was made has a much
lower chance of being accepted.
If English isn't your first language, don't worry about it and try to
communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.