Skip to content

Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative (backport #15289)#15290

Merged
michaelklishin merged 2 commits intov4.2.xfrom
mergify/bp/v4.2.x/pr-15289
Jan 17, 2026
Merged

Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative (backport #15289)#15290
michaelklishin merged 2 commits intov4.2.xfrom
mergify/bp/v4.2.x/pr-15289

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jan 17, 2026

This has been driving me nuts for a while because it results in a panic in one https://github.com/michaelklishin/rabbitmq-http-api-rs test.

These computed values can be reported as negative due to ETS tables being concurrently added, removed and updated.

So simply report 0 in such cases.

This is an automatic backport of pull request #15289 done by [Mergify](https://mergify.com).

@mergify
Copy link
Copy Markdown
Author

mergify bot commented Jan 17, 2026

Cherry-pick of 4d5f0f7 has failed:

On branch mergify/bp/v4.2.x/pr-15289
Your branch is ahead of 'origin/v4.2.x' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 4d5f0f780.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbit/Makefile

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the make label Jan 17, 2026
@michaelklishin
Make sure that "Other ETS" and "Other system" memory metrics are neve…
21b491a 
…r negative

They can become negative due to ETS tables being concurrently
added, removed and updated.

So simply report 0 in such cases.

(cherry picked from commit 6e7bf23)
@michaelklishin michaelklishin force-pushed the mergify/bp/v4.2.x/pr-15289 branch 2 times, most recently from a48d163 to 881cb60 Compare January 17, 2026 04:14
@michaelklishin michaelklishin force-pushed the mergify/bp/v4.2.x/pr-15289 branch from 881cb60 to 6cee8ed Compare January 17, 2026 04:14
@michaelklishin michaelklishin added this to the 4.2.3 milestone Jan 17, 2026
@michaelklishin michaelklishin merged commit 4923096 into v4.2.x Jan 17, 2026
575 of 577 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.2.x/pr-15289 branch January 17, 2026 05:34
mergify bot pushed a commit that referenced this pull request Jan 17, 2026
@michaelklishin @mergify
Resolve conflicts #15289 #15290
d052c71 
(cherry picked from commit 6cee8ed)
@mergify mergify bot mentioned this pull request Jan 17, 2026
Merged
michaelklishin added a commit that referenced this pull request Jan 17, 2026
@michaelklishin
Resolve conflicts #15289 #15290 #15291
95735d3
michaelklishin added a commit that referenced this pull request Jan 17, 2026
@michaelklishin
Merge pull request #15291 from rabbitmq/mergify/bp/v4.1.x/pr-15290
6b24a9c 
Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative (backport #15289) (backport #15290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelklishin michaelklishin

Labels

conflicts make

Projects

None yet

Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

1 participant

@michaelklishin