Skip to content

Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative#15289

Merged
michaelklishin merged 2 commits intomainfrom
mk-negative-ets-table-and-system-memory-metrics
Jan 17, 2026
Merged

Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative#15289
michaelklishin merged 2 commits intomainfrom
mk-negative-ets-table-and-system-memory-metrics

Conversation

@michaelklishin
Copy link
Copy Markdown
Collaborator

@michaelklishin michaelklishin commented Jan 17, 2026

This has been driving me nuts for a while because it results in a panic in one https://github.com/michaelklishin/rabbitmq-http-api-rs test.

These computed values can be reported as negative due to ETS tables being concurrently added, removed and updated.

So simply report 0 in such cases.

@michaelklishin michaelklishin added this to the 4.3.0 milestone Jan 17, 2026
@mergify mergify bot added the make label Jan 17, 2026
michaelklishin added a commit to michaelklishin/rabbitmq-http-api-rs that referenced this pull request Jan 17, 2026
michaelklishin added a commit to michaelklishin/rabbitmq-http-api-rs that referenced this pull request Jan 17, 2026
…r negative

They can become negative due to ETS tables being concurrently
added, removed and updated.

So simply report 0 in such cases.
@michaelklishin michaelklishin force-pushed the mk-negative-ets-table-and-system-memory-metrics branch from 92b03a4 to 4d5f0f7 Compare January 17, 2026 03:30
@michaelklishin michaelklishin merged commit 084c63b into main Jan 17, 2026
290 of 291 checks passed
@michaelklishin michaelklishin deleted the mk-negative-ets-table-and-system-memory-metrics branch January 17, 2026 04:01
michaelklishin added a commit that referenced this pull request Jan 17, 2026
michaelklishin added a commit that referenced this pull request Jan 17, 2026
Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative (backport #15289)
mergify bot pushed a commit that referenced this pull request Jan 17, 2026
(cherry picked from commit 6cee8ed)
michaelklishin added a commit that referenced this pull request Jan 17, 2026
michaelklishin added a commit that referenced this pull request Jan 17, 2026
Make sure that "Other ETS" and "Other system" memory metrics are never reported as negative (backport #15289) (backport #15290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant