Adding a new Grunt task to enable Node.js testing.#458
Conversation
There was a problem hiding this comment.
Let's extend this note: When we add more tests like this, spawn a process to make sure modifications to the QUnit object don't affect other test runs. Or modifications to the global object.
|
@scottgonzalez @jzaefferer @timmywil Thanks for the feedback, will update today. |
There was a problem hiding this comment.
This whole function seems bogus, I created #459 for that.
|
Glad to see this enhanced PR. Thanks, @JamesMGreene ! |
|
Maybe remove the "Closes" for the other two pull requests from the commit message since those are already closed and essentially merged into this one). The reference could be here in the pull message and/or comment thread, but shouldn't be in the commit message (when landing we should add "Closes #458" though. |
|
We finally have a project wide decision for AMD support. For QUnit we want to support the returnExports pattern, where we can use the simplified one since QUnit has no dependencies. James, can you add the define check and call, so that we have the whole exporting figured out? |
|
Should also peek at: https://npmjs.org/package/grunt-nodequnit |
|
Replaced with #493 |
This is an enhanced version of @twada's PRs #401 and #410. Thanks, @twada!