Non browser support#493
Merged
Merged
Conversation
This was referenced Dec 6, 2013
Contributor
There was a problem hiding this comment.
Just a side note. "predef" is antiquated. "globals": { "module": false } would be the new hotness.
Contributor
|
👍 I'm excited about this. |
Member
|
Thanks, @jzaefferer. I'm relieved that this is getting taken care of despite my current unavailability. 🤘 |
Contributor
There was a problem hiding this comment.
Why is this grunt.verbose.ok() instead of grunt.verbose.writeln()?
Member
Author
There was a problem hiding this comment.
I'm going to remove this, since its the only log line that requires the verbose flag and there's no other logs for a normal run.
Contributor
|
A few of these lines are >100 characters. Not sure if you plan on just waiting for the rest of the cleanup to fix that. |
Member
Author
|
Yeah, that cleanup will have to wait a little longer. |
The require path changed during the module refactor, but wasn't updated here. The QUnit.load() call is currently necessary for any tests to run. This needs another review.
Avoids addEvent() getting called in non-browser envs.
Checks for `window` to export in browsers, module.exports to export in node or comparable CommonJS envs.
Member
Author
|
Landed in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #458 and their predecessors. I've taken the changes James made, rebased them on top of master (the grand module split), then split everything up into small commits, in hopefully a sane order. I've addressed the feedback from the #458 PR.
When reviewing, please consider checking the individual commits. That should make the reviewing a lot easier as well.
The
Export:commit deserves special attention. I got sick of the twisted logic we had there, so I changed them to only export to properties that we actually check for. It works in the context of what we're testing.