Add UpdatesGuard type wrapper for updates_guard by Copilot · Pull Request #8031 · qdrant/qdrant

Copilot · 2026-02-02T21:30:56Z

Create a newtype wrapper UpdatesGuard for parking_lot::MutexGuard<'_, ()>
Update function signatures in segment_holder/snapshot.rs to use the new type
Update the acquire_updates_lock method to return the new type
Verify all usages compile correctly
Fix linter issue (trailing space in doc comment)
Remove unnecessary new() method, use tuple constructor directly

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

generall · 2026-02-03T00:06:48Z

@copilot this doesn't change anything

Co-authored-by: generall <1935623+generall@users.noreply.github.com>

Copilot · 2026-02-03T00:14:40Z

@copilot this doesn't change anything

I've now implemented the type wrapper. Created a newtype UpdatesGuard<'a> that wraps parking_lot::MutexGuard<'a, ()> to make its purpose clearer - guaranteeing no update operations are happening during critical sections. The type is used in try_unproxy_segment and unproxy_all_segments functions. Changes in commit 306c16c.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

esm.ubuntu.com
- Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https /tmp/apt.data.dxPTNe -O3 -Wall .rli�� -1949cf8c6b5b557f/ring-0.17.13/i--gdwarf-4 472.rlib bin/rustc 189213.rlib 44.rlib stup/toolchains/build_script_build bin/rustc (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

generall · 2026-02-03T01:12:15Z

@copilot fix linter issues

Co-authored-by: generall <1935623+generall@users.noreply.github.com>

Copilot · 2026-02-03T01:17:10Z

@copilot fix linter issues

Fixed the linter issue - removed trailing space in the doc comment. The formatter now passes. Changes in commit 78d1eb8.

monoid · 2026-02-03T10:02:49Z

lib/shard/src/segment_holder/locked.rs

+
+impl<'a> UpdatesGuard<'a> {
+    /// Create a new UpdatesGuard from a MutexGuard.
+    fn new(guard: parking_lot::MutexGuard<'a, ()>) -> Self {


I don't think new is needed. Tuple struct constructor is enough the single usage, and new is not public (and shouldn't be).

Removed the unnecessary new() method. Now using the tuple constructor directly: UpdatesGuard(self.updates_mutex.lock()). Changes in commit 74f5353.

generall · 2026-02-03T10:37:47Z

@copilot fix linter and comments

Co-authored-by: generall <1935623+generall@users.noreply.github.com>

Copilot · 2026-02-03T10:41:53Z

@copilot fix linter and comments

Fixed - removed unnecessary new() method and verified formatter passes. Changes in commit 74f5353.

* non-locking retrieve * optimization & write exclusive lock via upgradable_read * faster segment holder locks debug (#8024) * fix deadlock * move LockedSegmentHolder into a dedicated file * reorder locks for snapshot * fmt * upd comments * Update lib/collection/src/collection_manager/optimizers/segment_optimizer.rs Co-authored-by: Ivan Boldyrev <ivan.boldyrev@qdrant.com> * Add UpdatesGuard type wrapper for updates_guard (#8031) * Initial plan * Add UpdatesGuard newtype wrapper for updates_guard Co-authored-by: generall <1935623+generall@users.noreply.github.com> * Fix linter issue - remove trailing space in doc comment Co-authored-by: generall <1935623+generall@users.noreply.github.com> * Remove unnecessary new() method, use tuple constructor directly Co-authored-by: generall <1935623+generall@users.noreply.github.com> * fix clippy --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: generall <1935623+generall@users.noreply.github.com> Co-authored-by: generall <andrey@vasnetsov.com> * Remove aliassed lifetime Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> --------- Co-authored-by: Ivan Boldyrev <ivan.boldyrev@qdrant.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: generall <1935623+generall@users.noreply.github.com> Co-authored-by: Tim Visée <tim+github@visee.me> Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com>

Initial plan

8b653a4

Copilot AI assigned Copilot and generall Feb 2, 2026

Copilot AI mentioned this pull request Feb 2, 2026

faster segment holder locks #8007

Merged

Copilot AI requested a review from generall February 2, 2026 21:46

Copilot stopped work on behalf of generall due to an error February 2, 2026 21:46
Copilot has encountered an error. See logs for additional details.

Copilot started work on behalf of generall February 3, 2026 00:07 View session

Add UpdatesGuard newtype wrapper for updates_guard

306c16c

Co-authored-by: generall <1935623+generall@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Address feedback on type wrapper for updates_guard~~ Add UpdatesGuard type wrapper for updates_guard Feb 3, 2026

Copilot finished work on behalf of generall February 3, 2026 00:16

Copilot started work on behalf of generall February 3, 2026 01:12 View session

Fix linter issue - remove trailing space in doc comment

78d1eb8

Co-authored-by: generall <1935623+generall@users.noreply.github.com>

Copilot finished work on behalf of generall February 3, 2026 01:17

monoid reviewed Feb 3, 2026

View reviewed changes

Copilot started work on behalf of generall February 3, 2026 10:38 View session

Remove unnecessary new() method, use tuple constructor directly

74f5353

Co-authored-by: generall <1935623+generall@users.noreply.github.com>

Copilot finished work on behalf of generall February 3, 2026 10:42

fix clippy

c38155b

generall marked this pull request as ready for review February 3, 2026 11:35

generall merged commit d7039ce into faster-segment-holder-locks Feb 3, 2026
11 checks passed

generall deleted the copilot/sub-pr-8007 branch February 3, 2026 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add UpdatesGuard type wrapper for updates_guard#8031

Add UpdatesGuard type wrapper for updates_guard#8031
generall merged 5 commits intofaster-segment-holder-locksfrom
copilot/sub-pr-8007

Copilot AI commented Feb 2, 2026 •

edited

Loading

Uh oh!

generall commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

generall commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

monoid Feb 3, 2026

Uh oh!

Copilot AI Feb 3, 2026

Uh oh!

generall commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

generall commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

generall commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

monoid Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

generall commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 2, 2026 •

edited

Loading

Copilot AI commented Feb 3, 2026 •

edited

Loading