faster segment holder locks debug#8024
Merged
generall merged 5 commits intofaster-segment-holder-locksfrom Jan 31, 2026
Merged
Conversation
generall
added a commit
that referenced
this pull request
Feb 3, 2026
* non-locking retrieve * optimization & write exclusive lock via upgradable_read * faster segment holder locks debug (#8024) * fix deadlock * move LockedSegmentHolder into a dedicated file * reorder locks for snapshot * fmt * upd comments * Update lib/collection/src/collection_manager/optimizers/segment_optimizer.rs Co-authored-by: Ivan Boldyrev <ivan.boldyrev@qdrant.com> * Add UpdatesGuard type wrapper for updates_guard (#8031) * Initial plan * Add UpdatesGuard newtype wrapper for updates_guard Co-authored-by: generall <1935623+generall@users.noreply.github.com> * Fix linter issue - remove trailing space in doc comment Co-authored-by: generall <1935623+generall@users.noreply.github.com> * Remove unnecessary new() method, use tuple constructor directly Co-authored-by: generall <1935623+generall@users.noreply.github.com> * fix clippy --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: generall <1935623+generall@users.noreply.github.com> Co-authored-by: generall <andrey@vasnetsov.com> * Remove aliassed lifetime Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> --------- Co-authored-by: Ivan Boldyrev <ivan.boldyrev@qdrant.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: generall <1935623+generall@users.noreply.github.com> Co-authored-by: Tim Visée <tim+github@visee.me> Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com>
generall
added a commit
that referenced
this pull request
Feb 9, 2026
* non-locking retrieve * optimization & write exclusive lock via upgradable_read * faster segment holder locks debug (#8024) * fix deadlock * move LockedSegmentHolder into a dedicated file * reorder locks for snapshot * fmt * upd comments * Update lib/collection/src/collection_manager/optimizers/segment_optimizer.rs Co-authored-by: Ivan Boldyrev <ivan.boldyrev@qdrant.com> * Add UpdatesGuard type wrapper for updates_guard (#8031) * Initial plan * Add UpdatesGuard newtype wrapper for updates_guard Co-authored-by: generall <1935623+generall@users.noreply.github.com> * Fix linter issue - remove trailing space in doc comment Co-authored-by: generall <1935623+generall@users.noreply.github.com> * Remove unnecessary new() method, use tuple constructor directly Co-authored-by: generall <1935623+generall@users.noreply.github.com> * fix clippy --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: generall <1935623+generall@users.noreply.github.com> Co-authored-by: generall <andrey@vasnetsov.com> * Remove aliassed lifetime Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> --------- Co-authored-by: Ivan Boldyrev <ivan.boldyrev@qdrant.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: generall <1935623+generall@users.noreply.github.com> Co-authored-by: Tim Visée <tim+github@visee.me> Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix this deadlock:
Details
New lock schema: