Skip to content

Improve SnapshotManifest/SegmentManifest construction#7961

Merged
generall merged 2 commits intodevfrom
snapshot-manifest-fix
Jan 23, 2026
Merged

Improve SnapshotManifest/SegmentManifest construction#7961
generall merged 2 commits intodevfrom
snapshot-manifest-fix

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Jan 21, 2026 •
edited
Loading

Fix some bugs in how we collect SegmentManifest and assign versions to files. Partial snapshots should work much better now. 😬

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --workspace --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo added this to the Qdrant on Edge milestone Jan 21, 2026
@ffuugoo ffuugoo requested review from generall and timvisee January 21, 2026 17:35
@coderabbitai

This comment was marked as resolved.

Sign in to view
@generall generall force-pushed the snapshot-manifest-fix branch from 64cbbde to 492b75c Compare January 22, 2026 10:53
timvisee
timvisee reviewed Jan 22, 2026
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On immutable segments, I still see the version all of vector storage being bumped. Do we expect to fix that in this PR?

I used

bfb -n 10000 --indexing-threshold 1

and then

bfb -n 1 --indexing-threshold 1 --skip-create

@ffuugoo
Copy link
Contributor Author

ffuugoo commented Jan 22, 2026 •
edited
Loading

On immutable segments, I still see the version all of vector storage being bumped. Do we expect to fix that in this PR?

Not yet. It works correctly if you use on-disk vectors though.

UPD: #7971 should fix this.

@generall generall merged commit 1ef06b7 into dev Jan 23, 2026
15 checks passed
@generall generall deleted the snapshot-manifest-fix branch January 23, 2026 10:09
generall pushed a commit that referenced this pull request Feb 9, 2026
@ffuugoo @generall
Improve SnapshotManifest/SegmentManifest construction (#7961)
096f68f 
* Improve `SnapshotManifest`/`SegmentManifest` construction

* fixup! Improve `SnapshotManifest`/`SegmentManifest` construction

Fix stupidity 😬
@timvisee timvisee mentioned this pull request Feb 17, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvisee timvisee timvisee approved these changes

@generall generall generall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Qdrant on Edge

Development

Successfully merging this pull request may close these issues.

3 participants

@ffuugoo @timvisee @generall