Conversation
Member
generall
commented
Jan 22, 2026
- WIP: introduce new vector store type
- handling of InRamMmap
- fmt
- feature-flag
- fmt
9 tasks
ffuugoo
reviewed
Jan 22, 2026
lib/collection/src/collection_manager/optimizers/segment_optimizer.rs
Outdated
Show resolved
Hide resolved
ffuugoo
requested changes
Jan 22, 2026
lib/segment/src/segment_constructor/segment_constructor_base.rs
Outdated
Show resolved
Hide resolved
timvisee
reviewed
Jan 22, 2026
timvisee
reviewed
Jan 22, 2026
lib/segment/src/vector_storage/dense/memmap_dense_vector_storage.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
a9ec179 to
e7eeb03
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
I have a proposal how to make this sane, because right now it's completely unreadable. match (vector_config.storage_type, vector_storage.multivector_config) {
(VectorStorageType::Mmap, None) => open_mmap_vector_storage(..., true),
(VectorStorageType::InRamMmap, None) => open_mmap_vector_storage(..., true),
(VectorStorageType::Mmap, Some(multivector)) => open_appendable_memmap_multi_vector_storage(..., false),
(VectorStorageType::InRamMmap, Some(multivector)) => open_appendable_memmap_multi_vector_storage(..., true),
// etc...
} |
Co-authored-by: Tim Visée <tim+github@visee.me>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ffuugoo
approved these changes
Jan 22, 2026
Contributor
ffuugoo
left a comment
There was a problem hiding this comment.
LGTM, we can fix cosmetic stuff later
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Jan 23, 2026
Member
|
Since this is feature flagged it should be safe to merge. Doing so now. |
generall
added a commit
that referenced
this pull request
Feb 9, 2026
* WIP: introduce new vector store type * handling of InRamMmap * fmt * feature-flag * fmt * Use if else Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com> * Update lib/common/common/src/flags.rs Co-authored-by: Tim Visée <tim+github@visee.me> * also choose madvise for single-file in-ram-mmap * simplify generics * gpu fix * fix bug --------- Co-authored-by: Tim Visée <tim+github@visee.me> Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.