feat/shard-ops-timeout by dancixx · Pull Request #7750 · qdrant/qdrant

dancixx · 2025-12-11T16:38:20Z

All Submissions:

Contributions should target the dev branch. Did you create your branch from dev?
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

Does your submission pass tests?
Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

lib/api/src/grpc/proto/points.proto

lib/collection/src/collection/point_ops.rs

lib/collection/src/shards/local_shard/shard_ops.rs

lib/collection/src/shards/replica_set/update.rs

lib/collection/src/update_workers/update_worker.rs

xzfc · 2025-12-16T22:44:47Z

Merging #7475 introduced merge conflicts in this branch, so I rebased it.

lib/collection/src/shards/replica_set/update.rs

src/common/inference/service.rs

lib/collection/src/shards/forward_proxy_shard.rs

timvisee · 2026-01-07T17:10:20Z

I'd like to do a proper (manual) test before I approve this PR.

I do see the new wait_timeout status when running this branch, which is good.

However, on dev I still fail to reproduce the case where we mark replicas as dead.

generall · 2026-01-07T17:38:07Z

However, on dev I still fail to reproduce the case where we mark replicas as dead.

were you able to trigger timeout for update operation?

* feat: add shard-ops timeout * feat: add shard-ops timeout * feat: add missing timeout * fix: format * fix: type serialization * fix: bad wal flush logic * feat: add seperate wait_time * fix: linter issues * fix: linter * chore: make select more readable * fix: linter issues * chore: remove comment * chore: adjust comment * chore: update definition * chore: remove extra wait_timeout -> make timeout global * chore: remove wait_timeout from point_ops * chore: remove wait_timeout from grpc * refactor: make shard_ops more readable * chore: remove timeout from update_all * feat: propagate wait_timeout error * fix: clippy recommendation * chore: update wait timeout * refactor: update merge_successful_update_results * fix: tests inconsistency * fix: revert global ord, partialord for UpdateStatus * fix: integration test * fix: res ingoring * fix: review requests * fix: clippy * chore: revert back futures unordered * fix: resolve response status * force timeout for remote operations * fix: pr reviews * fix: switch to duration * Bump OpenAPI spec * feat: add serde_as * fix: timeout statu condition * Minor tweaks * Use tokio timeout directly rather than deadline * Revert schema generator permissions * Remove obsolete semi-colon --------- Co-authored-by: generall <andrey@vasnetsov.com> Co-authored-by: timvisee <tim@visee.me>

dancixx marked this pull request as draft December 11, 2025 16:38

This comment was marked as resolved.

Sign in to view

qdrant deleted a comment from coderabbitai bot Dec 11, 2025

dancixx force-pushed the feat/shard-ops-timeout branch from 444c32e to d6bda4f Compare December 12, 2025 12:31

dancixx marked this pull request as ready for review December 12, 2025 13:13

dancixx requested a review from generall December 12, 2025 13:14

dancixx marked this pull request as draft December 12, 2025 13:14

This comment was marked as resolved.

Sign in to view

dancixx marked this pull request as ready for review December 15, 2025 10:21

dancixx requested review from generall and removed request for generall December 15, 2025 10:21

This comment was marked as resolved.

Sign in to view