Merged
Conversation
timvisee
approved these changes
Oct 30, 2025
Member
|
We agreed to merge this after the 1.16 release. That way we prevent this messing with proto diff's when updating clients. We can merge this after the release. |
This was referenced Dec 16, 2025
Merged
timvisee
pushed a commit
that referenced
this pull request
Dec 18, 2025
* proto: doc comment style * proto: clang-format * proto: manually reflow some comments * proto: proofread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the style of our
.protofiles. Commits in this PR:1. doc comment style (automated)
Currenly, our
.protofiles use three different styles of comments: line comments on a separate line, multi-line block comments, and line comments at the end of a line. This snippet illustrates all three of them:qdrant/lib/api/src/grpc/proto/collections.proto
Lines 292 to 305 in 96a7a70
The first commit in this PR converts all comments into a single style which is proposed by the Protobuf Language Guide:
Conversion is done by running this script.
2. clang-format (automated)
The second commit runs
clang-formatto unify indenting/spaces. I believe that's the tool the company behind protobuf uses for their files.While I like auto-reflow, it's too blunt for an automated mass-edit, so I disabled it and manually split some of the longer lines.
3. manually reflow some comments
See line above.
4. proofread