Fix shard snapshots IO error, proxy first then flush#7427
Merged
Conversation
2a8d12e to
cead453
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
|
Status: @agourlay is running some test on this locally |
agourlay
approved these changes
Oct 20, 2025
Member
agourlay
left a comment
There was a problem hiding this comment.
Survived 1h20 crashing workload ✔️
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7404
When taking a shard snapshot, we proxy all segments and flush them.
It is important that we proxy first, and then flush. Proxying ensures that the segments won't change anymore. After that we can flush the last changes that were still pending.
If we do it the other way around, new changes might land in the segments after flush but before we proxy them. The background flush task might trigger another flush during the snapshot process, which conflicts on file IO.
All Submissions:
devbranch. Did you create your branch fromdev?