address parallel flushing problem in snapshot creation#7404
Merged
Conversation
timvisee
approved these changes
Oct 14, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Thanks! 🙏
We believe this is fine for snapshots (and snapshot transfer) because the following actions are strictly ordered:
- queue proxy is created
- segments are explicitly flushed
3 tasks
timvisee
pushed a commit
that referenced
this pull request
Nov 14, 2025
* address parallel flushing problem in snapshot creation * explicit flush in test
Merged
This was referenced Jan 2, 2026
9 tasks
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't really like to have a possibility of segment flush happaning in parallel.
Previously, we had a limitation per-segment, but now it is per shard.
This PR makes according changes to the snapshot-triggered flushes, so they are also per-shard and mutually exclusive.