Merged
Conversation
timvisee
reviewed
Sep 8, 2025
| /// This operation is blocking, it will only proceed once all current optimizations are complete | ||
| #[serde(alias = "optimizer_config")] | ||
| #[validate(nested)] | ||
| pub optimizers_config: Option<OptimizersConfigDiff>, // TODO: Allow updates for other configuration params as well |
Member
There was a problem hiding this comment.
We should likely add another validation rule on OptimizersConfigDiff.
Candidate:
deleted_threshold: [0.0, 1.0]
Member
Author
There was a problem hiding this comment.
Good call, it is already present in gRPC 👍
I took the liberty then to backport vacuum_min_vector_number as well from gRPC.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Sep 8, 2025
timvisee
pushed a commit
that referenced
this pull request
Sep 29, 2025
* Fix missing REST API validations misc. * add validation for deleted_threshold * backport vacuum_min_vector_number validation from gRPC
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various missing API validations.
Backported from #7216