Skip to content

[WIP] Fix missing API validations#7216

Closed
agourlay wants to merge 4 commits intodevfrom
fix-missing-API-validations-again
Closed

[WIP] Fix missing API validations#7216
agourlay wants to merge 4 commits intodevfrom
fix-missing-API-validations-again

Conversation

@agourlay
Copy link
Member

@agourlay agourlay commented Sep 5, 2025 •
edited
Loading

Found a few missing API validations:

  • update operations in update_batch
  • filter in set_payload and delete_payload
  • conditions in min_should
  • mmr in query
  • filter in facet_request
  • filter in filter_selector
  • quantization_config and strict mode config in collection_config
  • inference types

@generall
Copy link
Member

generall commented Sep 5, 2025

What exactly were we not validating?

@agourlay
Copy link
Member Author

agourlay commented Sep 5, 2025

@generall I updated the PR description with what I found so far.

@agourlay agourlay changed the title Fix missing API validations [WIP] Fix missing API validations Sep 5, 2025
@agourlay
Copy link
Member Author

agourlay commented Sep 5, 2025

I will split this in several PRs for easier review

This was referenced Sep 5, 2025
Merged
Merged
Merged
Merged
Merged
Draft
@agourlay
Copy link
Member Author

agourlay commented Sep 8, 2025 •
edited
Loading

everything applied in separate PRs

@agourlay agourlay closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agourlay @generall